feat: add connector for Parseable #32052
Conversation
dosubot
bot
added
data:connect
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Missing NULL Handling in Time Expressions ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/db_engine_specs/parseable.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| _time_grain_expressions = { | ||
| None: "{col}", | ||
| TimeGrain.SECOND: "date_trunc('second', {col})", | ||
| TimeGrain.MINUTE: "date_trunc('minute', {col})", | ||
| TimeGrain.HOUR: "date_trunc('hour', {col})", | ||
| TimeGrain.DAY: "date_trunc('day', {col})", | ||
| TimeGrain.WEEK: "date_trunc('week', {col})", | ||
| TimeGrain.MONTH: "date_trunc('month', {col})", | ||
| TimeGrain.QUARTER: "date_trunc('quarter', {col})", | ||
| TimeGrain.YEAR: "date_trunc('year', {col})", | ||
| } |
There was a problem hiding this comment.
Missing NULL Handling in Time Expressions 
Tell me more
What is the issue?
The time grain expressions don't account for possible NULL values in timestamp columns, which could cause queries to fail.
Why this matters
Queries may fail when processing NULL timestamp values, affecting data analysis and visualization reliability.
Suggested change ∙ Feature Preview
Add NULL handling to the time grain expressions:
_time_grain_expressions = {
None: "{col}",
TimeGrain.SECOND: "CASE WHEN {col} IS NULL THEN NULL ELSE date_trunc('second', {col}) END",
TimeGrain.MINUTE: "CASE WHEN {col} IS NULL THEN NULL ELSE date_trunc('minute', {col}) END",
# ... Apply similar pattern to other time grains
}
💬 Chat with Korbit by mentioning @korbit-ai.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
michael-s-molina
requested review from
betodealmeida,
mistercrunch,
villebro and
sadpandajoe
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32052 +/- ##
===========================================
+ Coverage 0 83.46% +83.46%
===========================================
Files 0 545 +545
Lines 0 39036 +39036
===========================================
+ Hits 0 32582 +32582
- Misses 0 6454 +6454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Nice! A few observations:
- Let's remove pinning to a specific version
- There seems to be some linting issues, please check CI logs for the specific errors
- Can you add a mention to the docs about this db? Docs are under
/docs(you can check how other db types are represented there)
FYI we're likely cutting the 5.0 release next week, so if you can fix these issues, we can probably just squeeze this into this version.
pyproject.toml
Outdated
| @@ -156,6 +156,7 @@ ocient = [ | |||
| "geojson", | |||
| ] | |||
| oracle = ["cx-Oracle>8.0.0, <8.1"] | |||
| parseable = ["sqlalchemy-parseable==0.1.3"] | |||
There was a problem hiding this comment.
Let's not pin this, but rather define upper/lower bounds if needed.
|
@villebro i have addressed your review comments. Thanks for the head's up on the release cycle. Would love to get this in. |
|
@AdheipSingh you may want to install pre-commit hooks as instructed here: https://superset.apache.org/docs/contributing/development#git-hooks it will automatically fix formatting issues and catch typical type errors during git commit. |
|
Apologies, newbie to python. Will install the githook moving forward. I installed pre-commit locally to fix this. 
|
|
@betodealmeida will probably know more, but do we need to add anything for dialect parsing here: superset/superset/sql/parse.py Line 45 in 1064ad5 |
@sadpandajoe I don't see Parseable here, so I assume we'll just fall back to the default dialect for now: https://github.com/tobymao/sqlglot/tree/main/sqlglot/dialects |
Interesting ! |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION