chore: Empty state refactor #31860

mistercrunch · 2025-01-15T08:19:19Z

making size a prop instead of one-component-per-size
fixing up the svg so its themable using currentColor
centralizing/fixing up references
simplify empty message in home page to simply "Nothing here yet" as the context in which the empty component shows up is clear enough, and the previous approach wast over-engineered

geido · 2025-01-15T16:49:07Z

superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

@@ -113,7 +113,7 @@ const SqlEditorLeftBar = ({
    'schema',
  ]);

-  const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
+  const [_emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);


Do we actually need this?

I think we need setEmptyResultsWithSearch, and are flushing position 1 of the array. Code is a bit cryptic to me here. Not sure why we need setEmptyResultsWithSearch

Since it's meant to be flushed, I could put it in a _ to make it more clear (and keep the spread operator) or hard reference useState(false)[1], WDYT?

I am not sure that we need this. It looks that originally the PR that introduced this was just meant to show some alternate text. I did some testing and I could not see anything breaking with just removing this entirely.

- making `size` a prop instead of one-component-per-size - fixing up the svg so its themable using `currentColor` - centralizing/fixing up references

mistercrunch · 2025-01-16T16:40:50Z

/testenv up

github-actions · 2025-01-16T16:41:01Z

@mistercrunch Processing your ephemeral environment request here.

github-actions · 2025-01-16T16:49:22Z

@mistercrunch Ephemeral environment spinning up at http://54.186.90.161:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas · 2025-01-21T20:09:47Z

/korbit-review

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Fix Detected
	Hardcoded Empty State Search Parameter ▹ view

Files scanned

File Path	Reviewed
superset-frontend/src/SqlLab/components/SouthPane/Results.tsx	✅
superset-frontend/src/features/datasets/AddDataset/DatasetPanel/MessageContent.tsx	✅
superset-frontend/src/SqlLab/components/QueryHistory/index.tsx	✅
superset-frontend/src/components/EmptyState/EmptyState.stories.tsx	✅
superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx	✅
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx	✅
superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx	✅
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx	✅
superset-frontend/src/features/datasets/AddDataset/LeftPanel/index.tsx	✅
superset-frontend/src/features/datasets/AddDataset/EditDataset/UsageTab/index.tsx	✅
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx	✅
superset-frontend/src/features/home/EmptyState.tsx	✅
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx	✅
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx	✅
superset-frontend/src/components/Chart/Chart.tsx	✅
superset-frontend/src/dashboard/components/gridComponents/Tab.jsx	✅
superset-frontend/src/dashboard/components/DashboardGrid.jsx	✅
superset-frontend/src/components/Chart/ChartRenderer.jsx	✅
superset-frontend/src/components/Table/index.tsx	✅
superset-frontend/src/components/EmptyState/index.tsx	✅
superset-frontend/src/components/ListView/ListView.tsx	✅
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx	✅
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx	✅
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx	✅
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx	✅
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

Chat with Korbit on issues we post by tagging @korbit-ai in your reply.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Naming ✅

Database Operations ✅

Documentation ✅

Logging ✅

Error Handling ✅

Systems and Environment ✅

Objects and Data Structures ✅

Readability and Maintainability ✅

Asynchronous Processing ✅

Design Patterns ✅

Third-Party Libraries ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

superset-frontend/src/features/datasets/AddDataset/LeftPanel/index.tsx

geido

Looks great. Thanks for doing this. Just a few nits above but approving otherwise.

geido · 2025-01-22T14:58:21Z

superset-frontend/package-lock.json

-      "version": "7.24.8",
-      "resolved": "https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.24.8.tgz",
-      "integrity": "sha512-pO9KhhRcuUyGnJWwyEgnRJTSIZHiT+vMD0kPeD+so0l7mxkMT19g3pjY9GTnHySck/hDzq+dtW/4VgnMkippsQ==",
+      "version": "7.25.9",


Just double-checking. Are these bumps necessary here?

I think I bumped babel-types (and maybe other libs (?)) to try and prevent some warning/console messages. I think they're not directly related to the PR but net-positive, will leave them in as they might be related to things I changed here.

geido · 2025-01-22T15:07:37Z

superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx

@@ -113,7 +113,7 @@ const SqlEditorLeftBar = ({
    'schema',
  ]);

-  const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
+  const [_emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);


I am not sure that we need this. It looks that originally the PR that introduced this was just meant to show some alternate text. I did some testing and I could not see anything breaking with just removing this entirely.

pull-request-size bot added the size/XL label Jan 15, 2025

dosubot bot added the change:frontend Requires changing the frontend label Jan 15, 2025

geido self-requested a review January 15, 2025 11:34

geido reviewed Jan 15, 2025

View reviewed changes

pull-request-size bot added size/XXL and removed size/XL labels Jan 16, 2025

chore: Empty state refactor

5640c74

- making `size` a prop instead of one-component-per-size - fixing up the svg so its themable using `currentColor` - centralizing/fixing up references

mistercrunch force-pushed the refactor_empty branch from 0b2a217 to 5640c74 Compare January 16, 2025 06:13

mistercrunch added 2 commits January 15, 2025 22:58

fixed two tets

3f82485

nothing here yet

a6746a6

github-actions bot added the dependencies:npm label Jan 16, 2025

github-actions bot added the preset-io label Jan 17, 2025

korbit-ai bot reviewed Jan 21, 2025

View reviewed changes

superset-frontend/src/features/datasets/AddDataset/LeftPanel/index.tsx Show resolved Hide resolved

geido approved these changes Jan 22, 2025

View reviewed changes

mistercrunch merged commit fcd1661 into master Jan 22, 2025
51 checks passed

mistercrunch deleted the refactor_empty branch January 22, 2025 21:20

sfirke pushed a commit to sfirke/superset that referenced this pull request Feb 12, 2025

chore: Empty state refactor (apache#31860)

8763ef5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Empty state refactor #31860

chore: Empty state refactor #31860

mistercrunch commented Jan 15, 2025 •

edited

Loading

geido Jan 15, 2025

mistercrunch Jan 15, 2025

mistercrunch Jan 21, 2025

geido Jan 22, 2025

mistercrunch commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

rusackas commented Jan 21, 2025

korbit-ai bot left a comment •

edited

Loading

geido left a comment

geido Jan 22, 2025

mistercrunch Jan 22, 2025

geido Jan 22, 2025

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

chore: Empty state refactor #31860

chore: Empty state refactor #31860

Conversation

mistercrunch commented Jan 15, 2025 • edited Loading

geido Jan 15, 2025

Choose a reason for hiding this comment

mistercrunch Jan 15, 2025

Choose a reason for hiding this comment

mistercrunch Jan 21, 2025

Choose a reason for hiding this comment

geido Jan 22, 2025

Choose a reason for hiding this comment

mistercrunch commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

rusackas commented Jan 21, 2025

korbit-ai bot left a comment • edited Loading

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

geido left a comment

Choose a reason for hiding this comment

geido Jan 22, 2025

Choose a reason for hiding this comment

mistercrunch Jan 22, 2025

Choose a reason for hiding this comment

geido Jan 22, 2025

Choose a reason for hiding this comment

mistercrunch commented Jan 15, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading