Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Card component background color #31483

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kgabryje
Copy link
Member

SUMMARY

After upgrading the Card component to antd 5, we forgot about the background color token, resulting in cards having blue-ish background color instead of gray.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image image

After:

image image

TESTING INSTRUCTIONS

Verify that the card components in SQL Lab (the query in the Results tab) and Dataset edit -> Settings have gray backgrounds

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Dec 16, 2024
@kgabryje kgabryje requested a review from rusackas December 16, 2024 17:29
@michael-s-molina
Copy link
Member

@kgabryje @geido I'm following the fixes for the Ant Design migration. Some bugs are hard to detect but this one seems really easy to check during the PR review. Are we missing some manual tests when reviewing these migrations?

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Dec 16, 2024
@rusackas
Copy link
Member

/korbit-review

@kgabryje kgabryje merged commit 4c380b4 into apache:master Dec 17, 2024
37 checks passed
@kgabryje
Copy link
Member Author

kgabryje commented Dec 17, 2024

@michael-s-molina on 1 hand I agree that this should have been caught by looking at the storybook during the review, but on the other - can't say for others, but I probably wouldn't notice that the color had changed. I wish details like this were caught by visual regression tests

@rusackas rusackas removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 17, 2024
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants