fix(explore): Styling issue in Search Metrics input field #31473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
requested review from
Antonio-RiveroMartnez,
geido and
michael-s-molina
rusackas
approved these changes
Dec 16, 2024
betodealmeida
pushed a commit
that referenced
this pull request
Jan 14, 2025
(cherry picked from commit 8be69aa)
tmsjordan
pushed a commit
to tmsdevelopment/superset
that referenced
this pull request
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following upgrade of Input component to antd 5, the "Search Metrics & Columns" field in Explore had some broken styles
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Open Explore, verify that Search Metrics & Columns input looks good - the placeholder should be centered, the input text and clear button should be aligned
ADDITIONAL INFORMATION