Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip covers the date selector in native filters #31472

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kgabryje
Copy link
Member

SUMMARY

After upgrading the Tooltip component to antd5, tooltips were covering the date selector in horizontal native filters bar and preventing clicking on the filter.
This PR fixes it by removing getPopupContainer prop from Tooltip, which was introduced in #24617 to fix an issue with tooltip position when user scrolls the page.
Apparently Antd v5 fixed this behaviour and we no longer need to pass getPopupContainer.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2024-12-16.at.12.14.46.mov

After:

Screen.Recording.2024-12-16.at.12.04.31.mov

TESTING INSTRUCTIONS

  1. Add a date native filter
  2. Set a date
  3. Verify that the tooltip is not covering the filter control and that its placement doesn't change when you scroll
  4. Make sure that it works as expected both in horizontal and vertical filter bar

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Dec 16, 2024
@kgabryje kgabryje merged commit 9b28a6e into apache:master Dec 16, 2024
36 checks passed
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants