chore: deprecate pip-compile-multi in favor or uv #31313
Conversation
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
doc
mistercrunch
added
the
v5.0
mistercrunch
force-pushed
the
uv_pip_compile
branch
from
2475449 to
3cb6505
Compare
mistercrunch
changed the title
|
/korbit-review |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
| Category | Issue |
|---|---|
 |
Incorrect Input File Specification for Base Requirements ▹ view |
|
Missing UV Command Validation ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| scripts/uv-pip-compile.sh | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
scripts/uv-pip-compile.sh
Outdated
| # Generate the requirements/base.txt file | ||
| uv pip compile pyproject.toml -c requirements/base.in -o requirements/base.txt $ADDITIONAL_ARGS |
There was a problem hiding this comment.
Incorrect Input File Specification for Base Requirements 
Tell me more
What is the issue?
The first command uses requirements/base.in as a constraint (-c) while it should be using it as an input file since it's the primary source for base.txt.
Why this matters
Using base.in as a constraint instead of an input file means the dependencies specified in base.in might not be properly included in the final requirements file, potentially leading to missing dependencies.
Suggested change
Replace the first command with:
uv pip compile pyproject.toml requirements/base.in -o requirements/base.txt $ADDITIONAL_ARGS
Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
There was a problem hiding this comment.
@mistercrunch is this accurate? ¯\_(ツ)_/¯
There was a problem hiding this comment.
requirements.in really is used as a set of constraints here, the name might be confusing though. I could rename to base-constraints.txt for clarity
There was a problem hiding this comment.
I could probably also merge the constraints in pyproject.toml so it's all in one place
|
Hey @mistercrunch very nice to see! It's crazy fast, hey? |
michael-s-molina
removed
the
v5.0
pip-compile-multi hasn't been working super well for us. It has a few bugs, is pretty slow, and turns out
uvsupports our use case much better and at blazing speeds.