-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable cross filtering on charts with no dimensions #30176
Conversation
/testenv up |
@kgabryje Ephemeral environment spinning up at http://18.246.229.36:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgabryje @yousoph I have no problem with cutting the scope down for 4.1.0 and simply disabling cross filter for charts with no dimensions. Keep in mind though that this should not be the final solution as our x-axis supports categorical, temporal and numeric types which could be used in a cross filter. One simple example is when a user creates a bar chart and the x-axis is categorical. By the way, Drill By works for this scenario so I would expect cross filters to work too.
Screen.Recording.2024-09-06.at.09.05.04.mov
Ephemeral environment shutdown and build artifacts deleted. |
@michael-s-molina Yes I 100% agree that we should integrate cross-filtering with x-axis. This PR aims to temporarily remove confusing user experience and unblock 4.1 release. |
(cherry picked from commit 3aafd29)
SUMMARY
Cross filtering feature is designed to apply filters based on a dimension that user clicked in the source chart.
In some chart plugins, when the chart has no dimensions (only metric series), click on a metric would emit an empty cross filter, providing confusing user experience.
This PR disables cross filtering on charts that have no dimensions set.
Additionally, some charts were marked as compatible with cross filtering feature (
behaviors: [Behavior.InteractiveChart]
), but were in fact not implementing the feature. In those charts I removed the behavior and added aTODO
comment to implement cross filtering.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION