-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Partition calls from Jinja context #30019
fix: Partition calls from Jinja context #30019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30019 +/- ##
===========================================
+ Coverage 60.48% 83.69% +23.20%
===========================================
Files 1931 528 -1403
Lines 76236 38207 -38029
Branches 8568 0 -8568
===========================================
- Hits 46114 31976 -14138
+ Misses 28017 6231 -21786
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OMG will that fix the little There's a feature request to apply |
@mistercrunch Did you mean litter or forgot to specify what's little? 😄 |
Ooops, I wrote "little |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 07a90ad)
SUMMARY
In #28122, all methods that take a
table_name
and aschema
were updated to received aTable
instance. Unfortunately, the Jinja context calls to partition methods were not updated breaking the functionality. This PR fixes the problem by making the necessary changes.It's not in the scope of this PR to potentially support catalogs, which was the reason for the Table instance changes but this might be needed. @betodealmeida
TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION