Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add catalog_access to OBJECT_SPEC_PERMISSIONS #29650

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore: add catalog_access to OBJECT_SPEC_PERMISSIONS #29650

merged 1 commit into from
Jul 19, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

In testing catalogs more, I found that catalog_access is missing from OBJECT_SPEC_PERMISSIONS.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the authentication:access-control Rlated to access control label Jul 19, 2024
@betodealmeida betodealmeida requested a review from dpgaspar July 19, 2024 20:59
@betodealmeida betodealmeida merged commit ae0edbf into master Jul 19, 2024
35 of 36 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@betodealmeida @eschutho
chore: add catalog_access to OBJECT_SPEC_PERMISSIONS (#29650)
0d0f29d
@rusackas rusackas deleted the catalog_access_public branch July 25, 2024 18:28
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@betodealmeida @sadpandajoe
chore: add catalog_access to OBJECT_SPEC_PERMISSIONS (#29650)
f59fb6f 
(cherry picked from commit ae0edbf)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@sadpandajoe sadpandajoe sadpandajoe approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
authentication:access-control Rlated to access control 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @sadpandajoe @eschutho @mistercrunch