Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Required native filter message wrongfully appearing #29643

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: Required native filter message wrongfully appearing #29643

merged 1 commit into from
Jul 19, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

The required filter message introduced by #29456 was wrongfully appearing while the filters were still loading. This PR only changes the code to consider the showDashboard condition before displaying that message.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-07-19.at.11.10.52.mov
Screen.Recording.2024-07-19.at.11.06.51.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard labels Jul 19, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Jul 19, 2024
@michael-s-molina michael-s-molina merged commit 9487d6c into apache:master Jul 19, 2024
37 of 39 checks passed
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 22, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@michael-s-molina @eschutho
fix: Required native filter message wrongfully appearing (#29643)
4f55957
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@michael-s-molina @sadpandajoe
fix: Required native filter message wrongfully appearing (#29643)
fea187a 
(cherry picked from commit 9487d6c)
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Aug 13, 2024
michael-s-molina added a commit that referenced this pull request Aug 13, 2024
@michael-s-molina
fix: Required native filter message wrongfully appearing (#29643)
7eb1daa 
(cherry picked from commit 9487d6c)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @sadpandajoe @justinpark @mistercrunch