fix(sqllab): Show warning message when deprecated db is selected #29607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
justinpark
force-pushed
the
fix--show-error-message-on-deprecated-db-selected
branch
from
3e38002 to
4c62d8b
Compare
justinpark
changed the title
| const { findByText } = setup({ ...mockedProps, queryEditor }, store); | ||
| expect( | ||
| await findByText( | ||
| 'The selected database is currently deprecated and cannot be used', |
There was a problem hiding this comment.
Suggested change
| 'The selected database is currently deprecated and cannot be used', | |
| 'The database that was used to generate this query could not be found', |
There was a problem hiding this comment.
Another option perhaps "could not be reached"?
| <Alert | ||
| type="warning" | ||
| message={t( | ||
| 'The selected database is currently deprecated and cannot be used', |
There was a problem hiding this comment.
We cannot assume that the database was deprecated. It may be an intermittent error. I suggest a more generic message.
Suggested change
| 'The selected database is currently deprecated and cannot be used', | |
| 'The database that was used to generate this query could not be found', |
| 'The selected database is currently deprecated and cannot be used', | ||
| )} | ||
| description={t( | ||
| 'Choose one of the available databases from the panel on the left.', |
There was a problem hiding this comment.
Suggested change
| 'Choose one of the available databases from the panel on the left.', | |
| 'Choose one of the available databases on the left panel.', |
michael-s-molina
approved these changes
Jul 16, 2024
michael-s-molina
added
the
v4.0
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 13, 2024
) (cherry picked from commit db3fa8d)
github-actions
bot
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the selected database in the SQL editor is removed from the selection, the current implementation shows an empty state screen, making it appear as if all data has been lost.
This commit changes the behavior to display a deprecated state message when an SQL statement exists, clearly indicating the issue instead of showing an empty state screen.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--deprecated-message.mov
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION