Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): fix broken Storybook stories during development #29587

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix(storybook): fix broken Storybook stories during development #29587

merged 2 commits into from
Jul 15, 2024

Conversation

hainenber
Copy link
Contributor

fix(storybook): fix broken Storybook stories during development

SUMMARY

Fix Storybook stories that are currently broken.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Story name Before After
legacy-chart-plugins-legacy-plugin-chart-paired-t-test--basic image image
certifiedbadgewithtooltip--interactive-icon image image
legacy-chart-plugins-legacy-preset-chart-nvd3-boxplot--basic image image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

rusackas
rusackas approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusackas rusackas merged commit 462cda4 into apache:master Jul 15, 2024
35 of 36 checks passed
@hainenber hainenber deleted the fix-broken-storybook-stories branch July 15, 2024 15:35
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@hainenber @eschutho
fix(storybook): fix broken Storybook stories during development (#29587)
0f93c5c 
Signed-off-by: hainenber <[email protected]>
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels packages plugins size/S 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @rusackas