-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Japanese Translations #29567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29567 +/- ##
===========================================
+ Coverage 60.48% 83.68% +23.20%
===========================================
Files 1931 524 -1407
Lines 76236 37771 -38465
Branches 8568 0 -8568
===========================================
- Hits 46114 31610 -14504
+ Misses 28017 6161 -21856
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @rusackas Thank you for approving our pull request. We changed the title to fit the form of the template. But there still is one more error regarding Cypress Is this something can be fixed on our end? We would appreciate for any support on this. BR |
@avintonOfficial 貢献していただきありがとうございます。Cypressを再実行してみます。 |
Co-authored-by: superset <[email protected]>
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
Introduces new feature or API
Removes existing feature or API