Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Japanese Translations #29567

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

avintonOfficial
Copy link
Contributor

SUMMARY

  • An unassigned translation was added.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:

  • Required feature flags:

  • Changes UI

  • Includes DB Migration (follow approval process in SIP-59)

    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API

  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels Jul 12, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (76d897e) to head (de22c5c).
Report is 966 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29567       +/-   ##
===========================================
+ Coverage   60.48%   83.68%   +23.20%     
===========================================
  Files        1931      524     -1407     
  Lines       76236    37771    -38465     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31610    -14504     
+ Misses      28017     6161    -21856     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.13% <ø> (-0.04%) ⬇️
javascript ?
mysql 77.00% <ø> (?)
postgres 77.08% <ø> (?)
presto 53.71% <ø> (-0.10%) ⬇️
python 83.68% <ø> (+20.20%) ⬆️
sqlite 76.56% <ø> (?)
unit 59.73% <ø> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avintonOfficial avintonOfficial changed the title Add Japanese Translations fix(i18n): Add Japanese Translations Jul 16, 2024
@avintonOfficial
Copy link
Contributor Author

Hi @rusackas

Thank you for approving our pull request.

We changed the title to fit the form of the template.

But there still is one more error regarding Cypress

Is this something can be fixed on our end?

We would appreciate for any support on this.

BR

@avintonOfficial avintonOfficial changed the title fix(i18n): Add Japanese Translations fix: Add Japanese Translations Jul 16, 2024
@zhaoyongjie
Copy link
Member

@avintonOfficial 貢献していただきありがとうございます。Cypressを再実行してみます。

@zhaoyongjie zhaoyongjie merged commit 5b79752 into apache:master Jul 18, 2024
41 of 43 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:japanese Translation related to Japanese language i18n Namespace | Anything related to localization size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants