chore(utils): Support select_columns with getUserOwnedObjects and split recentActivityObjs #29459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecentActivityObjs
…ecentActivityObjs
Vitor-Avila
force-pushed
the
utils-improvements
branch
from
c3e7e21 to
15567d5
Compare
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
…it recentActivityObjs (#29459)
github-actions
bot
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support for specifying a list of columns to be used in the
select_columnsparameter with thegetUserOwnedObjectshelper.It also splits the
getRecentActivityObjsso that the logic to fetch dashboards and charts is handled by a separate helper:getFilteredChartsandDashboards. This new helper also supports specifying values for theselect_columnsparameters (both for the chart and dashboard requests).These parameters are all optional, so it shouldn't impact any existing call/implementation. Please refer to #28609 for additional context on the
select_columnsparameter.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION