Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(key-value): convert command to dao #29344

Merged
merged 16 commits into from
Jul 1, 2024

simplify

d7752de
Select commit
Loading
Failed to load commit list.
Merged

chore(key-value): convert command to dao #29344

simplify
d7752de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 1, 2024 in 0s

83.87% (+23.38%) compared to 76d897e

View this Pull Request on Codecov

83.87% (+23.38%) compared to 76d897e

Details

Codecov Report

Attention: Patch coverage is 93.86792% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (76d897e) to head (d7752de).
Report is 393 commits behind head on master.

Files Patch % Lines
superset/distributed_lock/utils.py 64.28% 5 Missing ⚠️
superset/distributed_lock/__init__.py 85.00% 3 Missing ⚠️
superset/daos/key_value.py 97.05% 2 Missing ⚠️
superset/commands/distributed_lock/base.py 94.11% 1 Missing ⚠️
superset/commands/distributed_lock/create.py 95.23% 1 Missing ⚠️
superset/commands/distributed_lock/get.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29344       +/-   ##
===========================================
+ Coverage   60.48%   83.87%   +23.38%     
===========================================
  Files        1931      519     -1412     
  Lines       76236    37409    -38827     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31376    -14738     
+ Misses      28017     6033    -21984     
+ Partials     2105        0     -2105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.