Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Explorer): Fix minor errors in ExploreViewContainer syntax, add tests #29249

Merged
merged 1 commit into from
Jun 14, 2024
Merged

test(Explorer): Fix minor errors in ExploreViewContainer syntax, add tests #29249

merged 1 commit into from
Jun 14, 2024

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented Jun 14, 2024

SUMMARY

In creating these tests I found some logic errors in my previous additions to the component (#29234).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Run tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added explore Namespace | Anything related to Explore explore:error Related to general errors of Explore need:tests This PR requires tests labels Jun 14, 2024
@rtexelm rtexelm changed the title test(Explorer): Fix minor errors in ExploreViewContainer logic, add tests test(Explorer): Fix minor errors in ExploreViewContainer syntax, add tests Jun 14, 2024
@michael-s-molina michael-s-molina merged commit 2418efe into apache:master Jun 14, 2024
38 of 39 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 14, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 14, 2024
@rtexelm @michael-s-molina
test(Explorer): Fix minor errors in ExploreViewContainer syntax, add …
88967ba 
…tests (#29249)

(cherry picked from commit 2418efe)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@rtexelm @eschutho
test(Explorer): Fix minor errors in ExploreViewContainer syntax, add …
6fa714f 
…tests (#29249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:error Related to general errors of Explore explore Namespace | Anything related to Explore need:tests This PR requires tests size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtexelm @michael-s-molina @mistercrunch