Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow removal of Node & Worker replicas for custom HPA solutions #28762

Merged
merged 13 commits into from
Jun 5, 2024
Merged

feat(helm): allow removal of Node & Worker replicas for custom HPA solutions #28762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
41cd625
chore(helm): update values.yaml with new custom key for autoscaling
hanslemm May 29, 2024
be07601
chore(helm): deactivate hpa-node.yaml for custom scaling
hanslemm May 29, 2024
6d63d6b
chore(helm): deactive hpa-worker.yaml when custom autoscaling is true
hanslemm May 29, 2024
ce5cc1d
Update hpa-node.yaml
hanslemm Jun 5, 2024
6f378dc
Update hpa-worker.yaml
hanslemm Jun 5, 2024
d61cb4e
Update values.yaml
hanslemm Jun 5, 2024
fa3ae1f
Update README.md
hanslemm Jun 5, 2024
6566065
Update deployment.yaml
hanslemm Jun 5, 2024
ba40aab
Update deployment-worker.yaml
hanslemm Jun 5, 2024
b2cefea
Update README.md
hanslemm Jun 5, 2024
8dc6d4d
Update hpa-node.yaml
hanslemm Jun 5, 2024
eb1abfe
Update hpa-worker.yaml
hanslemm Jun 5, 2024
06b678d
Update values.yaml
hanslemm Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions helm/superset/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ On helm this can be set on `extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| supersetNode.readinessProbe.periodSeconds | int | `15` | |
| supersetNode.readinessProbe.successThreshold | int | `1` | |
| supersetNode.readinessProbe.timeoutSeconds | int | `1` | |
| supersetNode.replicaCount | int | `1` | |
| supersetNode.replicas.enabled | bool | `true` | |
| supersetNode.replicas.replicaCount | int | `1` | |
| supersetNode.resources | object | `{}` | Resource settings for the supersetNode pods - these settings overwrite might existing values from the global resources object defined above. |
| supersetNode.startupProbe.failureThreshold | int | `60` | |
| supersetNode.startupProbe.httpGet.path | string | `"/health"` | |
Expand Down Expand Up @@ -319,7 +320,8 @@ On helm this can be set on `extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| supersetWorker.podLabels | object | `{}` | Labels to be added to supersetWorker pods |
| supersetWorker.podSecurityContext | object | `{}` | |
| supersetWorker.readinessProbe | object | `{}` | No startup/readiness probes by default since we don't really care about its startup time (it doesn't serve traffic) |
| supersetWorker.replicaCount | int | `1` | |
| supersetWorker.replicas.enabled | bool | `true` | |
| supersetWorker.replicas.replicaCount | int | `1` | |
| supersetWorker.resources | object | `{}` | Resource settings for the supersetWorker pods - these settings overwrite might existing values from the global resources object defined above. |
| supersetWorker.startupProbe | object | `{}` | No startup/readiness probes by default since we don't really care about its startup time (it doesn't serve traffic) |
| supersetWorker.strategy | object | `{}` | |
Expand Down
4 changes: 2 additions & 2 deletions helm/superset/templates/deployment-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ metadata:
annotations: {{- toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
{{- if not .Values.supersetWorker.autoscaling.enabled }}
replicas: {{ .Values.supersetWorker.replicaCount }}
{{- if not .Values.supersetWorker.autoscaling.enabled and .Values.supersetWorker.replicas.enabled }}
replicas: {{ .Values.supersetWorker.replicas.replicaCount }}
{{- end }}
selector:
matchLabels:
Expand Down
4 changes: 2 additions & 2 deletions helm/superset/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ metadata:
annotations: {{- toYaml .Values.supersetNode.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
{{- if not .Values.supersetNode.autoscaling.enabled }}
replicas: {{ .Values.supersetNode.replicaCount }}
{{- if not .Values.supersetNode.autoscaling.enabled and .Values.supersetNode.replicas.enabled }}
replicas: {{ .Values.supersetNode.replicas.replicaCount }}
{{- end }}
{{- if .Values.supersetNode.strategy }}
strategy: {{- toYaml .Values.supersetNode.strategy | nindent 4 }}
Expand Down
8 changes: 6 additions & 2 deletions helm/superset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ hostAliases: []

# Superset node configuration
supersetNode:
replicaCount: 1
replicas:
enabled: true
replicaCount: 1
autoscaling:
enabled: false
minReplicas: 1
Expand Down Expand Up @@ -364,7 +366,9 @@ supersetNode:

# Superset Celery worker configuration
supersetWorker:
replicaCount: 1
replicas:
enabled: true
replicaCount: 1
autoscaling:
enabled: false
minReplicas: 1
Expand Down
Loading