fix: ensure numeric values for extra metadata_cache_timeout payloads

[kidusmakonnen]

SUMMARY

We identified an issue where FileSystemCache is used, setting values for table_cache_timeout and schema_cache_timeout in the database properties modal leads to failures in fetching schema and table lists in SQLLab. The requests to /api/v1/database/{dbId}/tables/?q=(force:!f,schema_name:{schemaName}) were returning a 422 UNPROCESSABLE ENTITY status.

The root cause of the issue was that table_cache_timeout and schema_cache_timeout values were being serialized as strings instead of numbers. The backend expected numeric values, resulting in the 422 error when it encountered strings. To resolve this, we need to ensure that these values are correctly converted to numbers before they are sent in the payload.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

bug-superset-db-timeout.mp4

After

Screencast.from.05-28-2024.05.46.23.AM.mp4

TESTING INSTRUCTIONS

1. Ensure CACHE_CONFIG is set to use FileSystemCache in config.py/superset_config.py
2. Go to Settings → Database Connections
3. Edit a DB connection
4. Go to Advanced → Performance
5. Set values to SCHEMA CACHE TIMEOUT and TABLE CACHE TIMEOUT
6. Go to SqlLab, select the DB you edited
7. Try to refresh the schema list and table list

ADDITIONAL INFORMATION

• Has associated issue: Fixes Cannot fetch schema list and table list in sqllab after setting values to table_cache_timeout and schema_cache_timeout #28735
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.