Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SIP-95): missing catalog cache key #28415

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(SIP-95): missing catalog cache key #28415

merged 2 commits into from
May 10, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

This commit aims to resolve the bugs that were introduced by SIP-95 (#28376).

  • Avoid fetching catalog API when multi-catalog is not allowed.
  • Fix cache key collision on schema caused by missing composite catalog key.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before After
Screenshot 2024-05-09 at 11 02 06 AM Screenshot 2024-05-09 at 11 05 11 AM
Screenshot 2024-05-09 at 11 08 30 AM Screenshot 2024-05-09 at 11 08 08 AM

TESTING INSTRUCTIONS

Go to SQL Lab and check the network tab checking api/v1/catalog

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark requested a review from betodealmeida May 9, 2024 18:16
@michael-s-molina michael-s-molina requested a review from eschutho May 9, 2024 18:18
betodealmeida
betodealmeida approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

superset-frontend/src/components/DatabaseSelector/index.tsx
@@ -278,7 +278,7 @@ export default function DatabaseSelector({
isFetching: loadingCatalogs,
refetch: refetchCatalogs,
} = useCatalogs({
dbId: currentDb?.value,
dbId: showCatalogSelector ? currentDb?.value : undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice! ❤️

@john-bodley john-bodley merged commit 3a62eab into apache:master May 10, 2024
30 checks passed
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@justinpark @jzhao62
fix(SIP-95): missing catalog cache key (apache#28415)
16d584c
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@justinpark @EnxDev
fix(SIP-95): missing catalog cache key (apache#28415)
1f9198e
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
fix(SIP-95): missing catalog cache key (apache#28415)
78166cd
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinpark @betodealmeida @mistercrunch @john-bodley