Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update links to reference docs listing Superset issue codes #28389

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: update links to reference docs listing Superset issue codes #28389

merged 1 commit into from
May 8, 2024

Conversation

jonaschn
Copy link
Contributor

@jonaschn jonaschn commented May 8, 2024 •
edited
Loading

SUMMARY

Replaces broken links for all referenced issue codes

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image
After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Outdated Links to Issue Codes (404 Not Found) #28388
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke sfirke changed the title fix: update links for issue codes fix: update links to reference docs listing Superset issue codes May 8, 2024
sfirke
sfirke approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2024
rusackas
rusackas approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm gonna try to find a way to automate at least catching these, if not fixing them.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label May 8, 2024
@sfirke sfirke merged commit c818569 into apache:master May 8, 2024
36 checks passed
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 9, 2024
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@jonaschn
fix: update links to reference docs listing Superset issue codes (apa…
01d96f0 
…che#28389)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@jonaschn @jzhao62
fix: update links to reference docs listing Superset issue codes (apa…
25e8c04 
…che#28389)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@jonaschn @EnxDev
fix: update links to reference docs listing Superset issue codes (apa…
12f7494 
…che#28389)
@jonaschn jonaschn deleted the fix-404-issue-codes branch June 3, 2024 12:32
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@jonaschn
fix: update links to reference docs listing Superset issue codes (apa…
886ebda 
…che#28389)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfirke sfirke sfirke approved these changes

@john-bodley john-bodley john-bodley approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lgtm This PR has been approved by a maintainer size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated Links to Issue Codes (404 Not Found)
5 participants
@jonaschn @rusackas @john-bodley @sfirke @mistercrunch