-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Contribution percentages for ECharts plugins #28368
fix: Contribution percentages for ECharts plugins #28368
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28368 +/- ##
==========================================
+ Coverage 60.48% 67.30% +6.81%
==========================================
Files 1931 1934 +3
Lines 76236 76787 +551
Branches 8568 8572 +4
==========================================
+ Hits 46114 51679 +5565
+ Misses 28017 23011 -5006
+ Partials 2105 2097 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rusackas Does the bot add this label because someone approved the PR or because it reviewed the changes and considered them good enough to merge? |
Because it was reviewed by a committer and is basically mergeable... we can turn it off if we'd like, I'm not sure it's helping much. |
Got it. I believe we can turn it off as it's not providing additional value. |
Ok, it's off now :) |
(cherry picked from commit 55f3b46)
SUMMARY
Fix percentages shown in tooltips of ECharts plugins that contain time offsets and contribution mode enabled. The ECharts version does not distinguish series and time shifts when calculating the contribution percentages as the legacy version does. Instead of showing something like series A 50%, series B 50%, series A (a year ago) 50%, series B (a year ago) 50%, it shows all series with 25%. With this fix, the contribution of time shifts are calculated independently.
This is another pre-requisite to unblock timeseries chart migrations.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that time shift contributions are calculated independently.
ADDITIONAL INFORMATION