Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(superset-ui-core): Migrate FallbackComponent.test to RTL #28359

Merged
merged 3 commits into from
May 7, 2024
Merged

refactor(superset-ui-core): Migrate FallbackComponent.test to RTL #28359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9477ef6
Migrate to RTL
rtexelm May 6, 2024
8baaf56
Remove screen import
rtexelm May 6, 2024
594ef25
Dry up render
rtexelm May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 34 additions & 32 deletions superset-frontend/packages/superset-ui-core/test/chart/components/FallbackComponent.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,42 +18,44 @@
*/

import React from 'react';
import { shallow } from 'enzyme';
import { render } from '@testing-library/react';
import '@testing-library/jest-dom';
import { FallbackProps } from 'react-error-boundary';
import { ThemeProvider, supersetTheme } from '../../../src/style';

import FallbackComponent from '../../../src/chart/components/FallbackComponent';

describe('FallbackComponent', () => {
const ERROR = new Error('CaffeineOverLoadException');
const STACK_TRACE = 'Error at line 1: x.drink(coffee)';

it('renders error and stack trace', () => {
const wrapper = shallow(
<FallbackComponent componentStack={STACK_TRACE} error={ERROR} />,
);
const messages = wrapper.find('code');
expect(messages).toHaveLength(2);
expect(messages.at(0).text()).toEqual('Error: CaffeineOverLoadException');
expect(messages.at(1).text()).toEqual('Error at line 1: x.drink(coffee)');
});
const renderWithTheme = (props: FallbackProps) =>
render(
<ThemeProvider theme={supersetTheme}>
<FallbackComponent {...props} />
</ThemeProvider>,
);

it('renders error only', () => {
const wrapper = shallow(<FallbackComponent error={ERROR} />);
const messages = wrapper.find('code');
expect(messages).toHaveLength(1);
expect(messages.at(0).text()).toEqual('Error: CaffeineOverLoadException');
});
const ERROR = new Error('CaffeineOverLoadException');
const STACK_TRACE = 'Error at line 1: x.drink(coffee)';

it('renders stacktrace only', () => {
const wrapper = shallow(<FallbackComponent componentStack={STACK_TRACE} />);
const messages = wrapper.find('code');
expect(messages).toHaveLength(2);
expect(messages.at(0).text()).toEqual('Unknown Error');
expect(messages.at(1).text()).toEqual('Error at line 1: x.drink(coffee)');
test('renders error and stack trace', () => {
const { getByText } = renderWithTheme({
componentStack: STACK_TRACE,
error: ERROR,
});
expect(getByText('Error: CaffeineOverLoadException')).toBeInTheDocument();
expect(getByText('Error at line 1: x.drink(coffee)')).toBeInTheDocument();
});

it('renders when nothing is given', () => {
const wrapper = shallow(<FallbackComponent />);
const messages = wrapper.find('code');
expect(messages).toHaveLength(1);
expect(messages.at(0).text()).toEqual('Unknown Error');
});
test('renders error only', () => {
const { getByText } = renderWithTheme({ error: ERROR });
expect(getByText('Error: CaffeineOverLoadException')).toBeInTheDocument();
});

test('renders stacktrace only', () => {
const { getByText } = renderWithTheme({ componentStack: STACK_TRACE });
expect(getByText('Unknown Error')).toBeInTheDocument();
expect(getByText('Error at line 1: x.drink(coffee)')).toBeInTheDocument();
});

test('renders when nothing is given', () => {
const { getByText } = renderWithTheme({});
expect(getByText('Unknown Error')).toBeInTheDocument();
});
Loading