fix(maps): adds Crimea back to Ukraine 🇺🇦 #28226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins
doc
rusackas
force-pushed
the
adding-crimea-to-ukraine-map
branch
from
e453e00 to
2957c9a
Compare
|
Oh, thank you for this commit. Btw, maybe also remove Crimea from Russia map? |
michael-s-molina
added
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Apr 29, 2024
9 tasks
jingyi-zhao-01
pushed a commit
to jingyi-zhao-01/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 4.0.1
🍒 4.0.2
🏷️ bot
|
Oh, thank you for this commit. But you made a mistake, there are real boundaries in the screenshot. |
|
@ZOY23 that's some cool fanfiction you have there (esp. Kherson lol), not sure how its related to real boundaries though? |
|
@rusackas recently wrote a great blog post on how the Superset project manages country maps, and what our policies are regarding contested areas. I kindly request users refrain from getting into this debate here - if anyone wants to contest our policies, you are welcome to post to our dev list, or join our in-person monthly town hall, to see if the wider community shares your views. |
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updates the Jupyter notebook to correct Natural Earth's data, and copy Crimea (back) onto Ukraine.
All references to Kiev are also now properly renamed to Kyiv
Czech Republic an Philippines Regions seem to be updated, as bycatch.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION