Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove deprecated ignoreTestFiles from Applitools Cypress #28197

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: Remove deprecated ignoreTestFiles from Applitools Cypress #28197

merged 1 commit into from
Apr 24, 2024

Conversation

geido
Copy link
Member

@geido geido commented Apr 24, 2024

SUMMARY

An empty ignoreTestFiles was used in Applitools Cypress. ignoreTestFiles has been deprecated. Removing it to resume operations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

Github action should run successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Apr 24, 2024
@geido geido merged commit a9075fd into master Apr 24, 2024
29 checks passed
@rusackas rusackas deleted the geido/fix/applitools-cypress branch April 24, 2024 21:03
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@geido @qleroy
fix: Remove deprecated ignoreTestFiles from Applitools Cypress (apach…
2e5f8b8 
…e#28197)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@geido @jzhao62
fix: Remove deprecated ignoreTestFiles from Applitools Cypress (apach…
a6a03a0 
…e#28197)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@geido
fix: Remove deprecated ignoreTestFiles from Applitools Cypress (apach…
cbc77e6 
…e#28197)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@rusackas rusackas rusackas approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @rusackas @kgabryje @mistercrunch