Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fixed pkg-config dependency in Dockerfile #27841

Closed
wants to merge 2 commits into from
Closed

build: fixed pkg-config dependency in Dockerfile #27841

wants to merge 2 commits into from

Conversation

goldjee
Copy link
Contributor

@goldjee goldjee commented Apr 1, 2024 •
edited by mistercrunch
Loading

SUMMARY

Fixed inability to build Docker image as described in issue #27792

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

According to the documentation, pull the repository and build image with command:

docker compose -f docker-compose-non-dev.yml up

closes #27792

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley requested a review from mistercrunch April 2, 2024 16:18
@mistercrunch mistercrunch mentioned this pull request Apr 2, 2024
Merged
@mistercrunch
Copy link
Member

Fixed CI and merged this PR -> #27855, thank you for contributing the solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg-config not found on docker compose build
2 participants
@goldjee @mistercrunch