-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new CSV upload form and API #27840
feat: new CSV upload form and API #27840
Conversation
/testenv up |
@dpgaspar Ephemeral environment spinning up at http://52.24.73.183:8080. Credentials are |
superset-frontend/src/features/databases/CSVUploadModal/index.tsx
Outdated
Show resolved
Hide resolved
Agreed @dpgaspar. We can definitely do a separate PR just to make all these modals look the same and use the same component. |
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.216.119.147:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dpgaspar!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work @dpgaspar and for addressing the comments! This is a great improvement to the project 👏🏼
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Continuing the work on deprecating/removing server side rendered pages, this adds a new React/Antd Form and backend API for CSV uploads.
maintains all the current functionality and adds the following benefits:
Backend:
api/v1
and command pattern.Frontend:
schemas
is a drop down related with the databases dropdownScreen.Recording.2024-04-12.at.17.28.21.mov
Still todo on this PR:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION