Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects some inaccuracies zh translation #27794

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

listeng
Copy link
Contributor

@listeng listeng commented Mar 30, 2024

SUMMARY

This PR primarily corrects some inaccuracies in the Chinese translation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

In the welcome page, when there is no data present, the text previously displayed "示例 xxx 将出现在此处" has been corrected to "xxx 将出现在此处". Additionally, some incorrect translations on other pages have also been rectified.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:chinese Translation related to Chinese language labels Mar 30, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

rusackas commented Apr 2, 2024

@zhaoyongjie would you be able to make sure the translations are all accurate? Seems fine to me otherwise.

@listeng
Copy link
Contributor Author

listeng commented Apr 3, 2024

@zhaoyongjie would you be able to make sure the translations are all accurate? Seems fine to me otherwise.

The original translations contained numerous errors that could easily mislead Chinese users. While we have not yet fully translated all entries, but we have corrected the errors and untranslated terms in the webui that relate to functions commonly used by our general user base, as identified through our own usage. We will continue with these work to improve the translations.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The new translation is more accurate.

@rusackas
Copy link
Member

rusackas commented Apr 3, 2024

Made a couple teensy commits that will hopefully unblock the linters.

@rusackas rusackas merged commit ebcf4e0 into apache:master Apr 4, 2024
40 checks passed
@listeng listeng deleted the fix-zh-translation branch April 5, 2024 15:49
@listeng listeng mentioned this pull request Apr 5, 2024
9 tasks
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:chinese Translation related to Chinese language i18n Namespace | Anything related to localization size/XXL 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants