Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "chore: bump pylint (#27711)" #27714

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 27, 2024

SUMMARY

This reverts #27711 as bumping Pylint won't fix the errors that are happening on master. It will also introduce many more validations that will throw additional Pylint errors.

After reverting #27711, we just need to merge #27710 to fix the errors.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title Revert "chore: bump pylint (#27711)" fix: Revert "chore: bump pylint (#27711)" Mar 27, 2024
@michael-s-molina michael-s-molina requested a review from a team March 27, 2024 17:46
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (a48f770) to head (a49970b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27714      +/-   ##
==========================================
- Coverage   69.77%   69.77%   -0.01%     
==========================================
  Files        1911     1911              
  Lines       75056    75056              
  Branches     8362     8362              
==========================================
- Hits        52374    52373       -1     
- Misses      20630    20631       +1     
  Partials     2052     2052              
Flag Coverage Δ
mysql 77.90% <ø> (+0.02%) ⬆️
postgres 78.02% <ø> (ø)
python 82.91% <ø> (-0.01%) ⬇️
sqlite 77.45% <ø> (ø)
unit 56.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

I approved both PRs.

@michael-s-molina michael-s-molina merged commit 528946d into apache:master Mar 27, 2024
39 of 42 checks passed
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants