-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db_engine): Add custom_user_agent when connecting to MotherDuck #27665
feat(db_engine): Add custom_user_agent when connecting to MotherDuck #27665
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27665 +/- ##
==========================================
+ Coverage 67.47% 69.89% +2.41%
==========================================
Files 1911 1911
Lines 75019 75033 +14
Branches 8352 8352
==========================================
+ Hits 50620 52445 +1825
+ Misses 22349 20538 -1811
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I can repro the failing CI step locally, but it succeeds if I set
It looks like other PRs are failing with the same issue Edit: this is now resolved but Python integration is failing. |
@betodealmeida Thanks for the review! this PR is now ready to merge ✅ |
SUMMARY
This PR adds a
custom_user_agent
key to the config that is passed to the SQLAlchemy engine for DuckDB. This is needed for MotherDuck so we can track usage of Superset.The PR also updates the
sqlalchemy_uri_placeholder
for DuckDB and MotherDuck.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
User agent before:
User agent after:
sqlalchemy_uri_placeholder
before:sqlalchemy_uri_placeholder
after:TESTING INSTRUCTIONS
Run unit tests.
ADDITIONAL INFORMATION