Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bar_chart): Stacked Bar chart with Time comparison in separated stacks #27589

Conversation

Antonio-RiveroMartnez
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez commented Mar 20, 2024

SUMMARY

When using the bar chart in stacked mode, the time comparison series are displayed on top of the original ones, making the chart render just one bar with all series.

This PR separates each time compare if any into its own stack so users can properly visualize the comparison data vs original ones.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Current:
error

New version with different stacks:
new

TESTING INSTRUCTIONS

Set up a bar chart with Style = Stacked
Add a time shift

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (f274c47) to head (9e6e9a1).
Report is 1393 commits behind head on master.

Files with missing lines Patch % Lines
...lugin-chart-echarts/src/Timeseries/transformers.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27589   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files        1910     1910           
  Lines       74802    74816   +14     
  Branches     8345     8350    +5     
=======================================
+ Hits        50467    50477   +10     
- Misses      22284    22287    +3     
- Partials     2051     2052    +1     
Flag Coverage Δ
javascript 57.39% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title feat(bar_chart): Stacked Bar chart with Time comparison: feat(bar_chart): Stacked Bar chart with Time comparison in separated stacks Mar 20, 2024
- Put comparison series into their own stack instead of pilling on top of original one
- Add tests for new util function
- Use the prefix when finding the time comparison series in string names
@Antonio-RiveroMartnez
Copy link
Member Author

/testenv up

Copy link
Contributor

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://54.213.205.67:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

- Handle when the offset is part of a group list
@Antonio-RiveroMartnez
Copy link
Member Author

/testenv up

Copy link
Contributor

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.86.157.162:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 8a715cc into apache:master Mar 22, 2024
29 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
eschutho pushed a commit that referenced this pull request Jun 5, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants