-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bar_chart): Stacked Bar chart with Time comparison in separated stacks #27589
feat(bar_chart): Stacked Bar chart with Time comparison in separated stacks #27589
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27589 +/- ##
=======================================
Coverage 67.46% 67.46%
=======================================
Files 1910 1910
Lines 74802 74816 +14
Branches 8345 8350 +5
=======================================
+ Hits 50467 50477 +10
- Misses 22284 22287 +3
- Partials 2051 2052 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Put comparison series into their own stack instead of pilling on top of original one - Add tests for new util function
- Use the prefix when finding the time comparison series in string names
a5e7663
to
914c00f
Compare
/testenv up |
@Antonio-RiveroMartnez Ephemeral environment spinning up at http://54.213.205.67:8080. Credentials are |
- Handle when the offset is part of a group list
/testenv up |
@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.86.157.162:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
When using the bar chart in stacked mode, the time comparison series are displayed on top of the original ones, making the chart render just one bar with all series.
This PR separates each time compare if any into its own stack so users can properly visualize the comparison data vs original ones.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Current:
![error](https://private-user-images.githubusercontent.com/38889534/314548246-ad633714-b14e-4e77-8912-03c9c80c4d4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODcyNTIsIm5iZiI6MTczOTI4Njk1MiwicGF0aCI6Ii8zODg4OTUzNC8zMTQ1NDgyNDYtYWQ2MzM3MTQtYjE0ZS00ZTc3LTg5MTItMDNjOWM4MGM0ZDRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE1MTU1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjOGJiN2Q1MTAxMzI4NDY2ZjcwNjAyZGFmYTk3NTQ1YmUyMWY2MjQxY2RmNGM2YzhiZTVjZTBkODFmN2Y2MDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JcrAdZrPpqcbVzznvlxvCjUanJVfTdlUC2bCcmD8vkw)
New version with different stacks:
![new](https://private-user-images.githubusercontent.com/38889534/314543317-9ee22404-5c04-4398-872d-fc87486deac5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODcyNTIsIm5iZiI6MTczOTI4Njk1MiwicGF0aCI6Ii8zODg4OTUzNC8zMTQ1NDMzMTctOWVlMjI0MDQtNWMwNC00Mzk4LTg3MmQtZmM4NzQ4NmRlYWM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDE1MTU1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjMDYzYWU5MGUzZGNiMmFhYWM4ZTY0MTFiOTk2YTljY2ZhNTMyYzUwMzE0MWQ5M2RjNGViNDU5ZWFjNmJiODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ovLwYERP6kWvtIgjDX6EwX5fFjgpPPZ4R05HbDoD_NU)
TESTING INSTRUCTIONS
Set up a bar chart with Style = Stacked
Add a time shift
ADDITIONAL INFORMATION