Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unit test for values_for_column #27469

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

I found this unit test in my local machine, I think I forgot to add it to #26946.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (fde93dc) to head (249c920).
Report is 1436 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27469      +/-   ##
==========================================
+ Coverage   67.34%   69.60%   +2.26%     
==========================================
  Files        1909     1909              
  Lines       74623    74662      +39     
  Branches     8324     8324              
==========================================
+ Hits        50255    51972    +1717     
+ Misses      22314    20636    -1678     
  Partials     2054     2054              
Flag Coverage Δ
mysql 78.02% <ø> (+0.02%) ⬆️
postgres 78.12% <ø> (+0.02%) ⬆️
python 82.91% <ø> (+4.68%) ⬆️
sqlite 77.57% <ø> (-0.05%) ⬇️
unit 56.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@betodealmeida betodealmeida merged commit 6a7e5c2 into master Mar 12, 2024
28 of 29 checks passed
@john-bodley john-bodley deleted the add_values_for_column_test branch March 12, 2024 17:17
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
eschutho pushed a commit that referenced this pull request Jun 5, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants