refactor: Migrate CopyToClipboard to typescript #27309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27309 +/- ##
==========================================
- Coverage 67.31% 67.29% -0.03%
==========================================
Files 1895 1910 +15
Lines 74202 75876 +1674
Branches 8219 8859 +640
==========================================
+ Hits 49949 51060 +1111
- Misses 22204 22680 +476
- Partials 2049 2136 +87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
geido
changed the title
michael-s-molina
added
review:checkpoint
|
I think most commits are not meant to be here. A git rebase should help |
EnxDev
force-pushed
the
chore/typescript-migration-CopyToClipboard
branch
from
9948196 to
e3cc719
Compare
|
Running CI 🤞 |
geido
approved these changes
Mar 1, 2024
geido
reviewed
Mar 1, 2024
| return ( | ||
| <> | ||
| {!this.props.hideTooltip ? ( | ||
| <Tooltip | ||
| id="copy-to-clipboard-tooltip" | ||
| placement="topRight" | ||
| style={{ cursor }} | ||
| title={this.props.tooltipText} | ||
| title={this.props.tooltipText || ''} |
There was a problem hiding this comment.
I am curious if this prop should be required?
michael-s-molina
added
review-after-release
john-bodley
removed
the
review:checkpoint
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate CopyToClipboard to typescript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION