-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade eyes-cypress to latest #27195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27195 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 1905 1905
Lines 74496 74498 +2
Branches 8323 8324 +1
=======================================
+ Hits 50064 50066 +2
Misses 22377 22377
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hmmm... we need to check the license on this, and I'm having a weirdly hard time doing so. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27195 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 1905 1905
Lines 74496 74498 +2
Branches 8323 8324 +1
=======================================
+ Hits 50064 50066 +2
Misses 22377 22377
Partials 2055 2055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
29455c5
to
4275f74
Compare
@mistercrunch yeah that's quite terrible. However, Applitools confirmed that for our case they are applying this license. From a conversation with Apache legal, it seems we should be ok with this. |
Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Evan Rusackas <[email protected]>
SUMMARY
Fixes #27184
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
CI should pass
ADDITIONAL INFORMATION