Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade eyes-cypress to latest #27195

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Conversation

geido
Copy link
Member

@geido geido commented Feb 21, 2024

SUMMARY

Fixes #27184

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

CI should pass

ADDITIONAL INFORMATION

  • Has associated issue: Update dependencies in superset-frontend package.json  #27184
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3818da8) 67.20% compared to head (a511442) 67.20%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27195   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files        1905     1905           
  Lines       74496    74498    +2     
  Branches     8323     8324    +1     
=======================================
+ Hits        50064    50066    +2     
  Misses      22377    22377           
  Partials     2055     2055           
Flag Coverage Δ
javascript 56.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

Hmmm... we need to check the license on this, and I'm having a weirdly hard time doing so.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (3818da8) to head (a511442).
Report is 302 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27195   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files        1905     1905           
  Lines       74496    74498    +2     
  Branches     8323     8324    +1     
=======================================
+ Hits        50064    50066    +2     
  Misses      22377    22377           
  Partials     2055     2055           
Flag Coverage Δ
javascript 56.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Apr 16, 2024
@rusackas rusackas force-pushed the chore/upgrade-applitools-eyes-cypress branch from 29455c5 to 4275f74 Compare April 16, 2024 18:33
@mistercrunch
Copy link
Member

Screenshot 2024-04-16 at 4 09 44 PM Screenshot 2024-04-16 at 4 09 59 PM

' this a recursive LICENSE!?

@mistercrunch
Copy link
Member

puzzlin'
Screenshot 2024-04-16 at 4 12 25 PM
Screenshot 2024-04-16 at 4 12 21 PM

@geido
Copy link
Member Author

geido commented Apr 17, 2024

@mistercrunch yeah that's quite terrible. However, Applitools confirmed that for our case they are applying this license. From a conversation with Apache legal, it seems we should be ok with this.

@geido geido merged commit f3c538a into master Apr 17, 2024
28 checks passed
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
jingyi-zhao-01 pushed a commit to jingyi-zhao-01/superset that referenced this pull request May 16, 2024
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
@rusackas rusackas deleted the chore/upgrade-applitools-eyes-cypress branch September 27, 2024 21:04
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm github_actions Pull requests that update GitHub Actions code size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies in superset-frontend package.json
5 participants