Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ephemeral env build and up dependency #26919

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix(ci): ephemeral env build and up dependency #26919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe19e2
fix(ci): ephemeral env build and up dependency
dpgaspar Jan 31, 2024
2279800
fix dep
dpgaspar Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ephemeral-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
echo "has-secrets=1" >> "$GITHUB_OUTPUT"
fi

ephemeral_env_comment:
ephemeral-env-comment:
needs: config
if: needs.config.outputs.has-secrets
name: Evaluate ephemeral env comment trigger (/testenv)
Expand Down Expand Up @@ -80,8 +80,8 @@ jobs:
core.setFailed(errMsg)

ephemeral-docker-build:
needs: ephemeral_env_comment
name: docker-build
needs: ephemeral-env-comment
name: ephemeral-docker-build
runs-on: ubuntu-latest
steps:
- name: Get Info from comment
Expand Down Expand Up @@ -148,9 +148,9 @@ jobs:
docker tag $SHA $ECR_REGISTRY/$ECR_REPOSITORY:$SHA
docker push -a $ECR_REGISTRY/$ECR_REPOSITORY

ephemeral_env_up:
needs: ephemeral_env_comment
if: needs.ephemeral_env_comment.outputs.slash-command == 'up'
ephemeral-env-up:
needs: [ephemeral-env-comment, ephemeral-docker-build]
if: needs.ephemeral-env-comment.outputs.slash-command == 'up'
name: Spin up an ephemeral environment
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:

- name: Update env vars in the Amazon ECS task definition
run: |
cat <<< "$(jq '.containerDefinitions[0].environment += ${{ needs.ephemeral_env_comment.outputs.feature-flags }}' < ${{ steps.task-def.outputs.task-definition }})" > ${{ steps.task-def.outputs.task-definition }}
cat <<< "$(jq '.containerDefinitions[0].environment += ${{ needs.ephemeral-env-comment.outputs.feature-flags }}' < ${{ steps.task-def.outputs.task-definition }})" > ${{ steps.task-def.outputs.task-definition }}

- name: Describe ECS service
id: describe-services
Expand Down
Loading