-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add all Trino dependencies for Kerberos enablement #26077
fix: Add all Trino dependencies for Kerberos enablement #26077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -371,6 +369,7 @@ werkzeug==2.3.3 | |||
# via | |||
# apache-superset | |||
# flask | |||
# flask-appbuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add a CI linting rule to make sure the requirements files are always up to date (I assume this PR didn't bring about this change). Any objections to me adding a step to the python lint CI workflow that does this in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to run pip-compile-multi --no-upgrade and make sure there's no resulting diff?
@john-bodley yeah, I was thinking something along those lines
01311cb
to
05ad639
Compare
05ad639
to
639fd80
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26077 +/- ##
=======================================
Coverage 69.10% 69.10%
=======================================
Files 1940 1940
Lines 75869 75869
Branches 8445 8445
=======================================
+ Hits 52427 52428 +1
+ Misses 21267 21266 -1
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closing in favor of #26119 as we likely don't want to bloat our CI dependencies when there is an alternative workaround. |
SUMMARY
Per our documentation, Superset supports Kerberos authentication for Trino, however installing the
superset[trino]
dependencies are not suffice as thetrino
package additionally requires the requests-kerberos package.Rather than defining
trino[kerberos]
as a dependency I though it would be prudent to definingtrino[all]
as this contains additional requirements like SQLAlchemy.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Ran
pip-compile-multi --no-upgrade
.ADDITIONAL INFORMATION