chore: replace "dashboard" -> "report" in chart email report modal

[sfirke]

SUMMARY

When setting up a new email report for a chart, the popup incorrectly says "dashboard" and "screenshot."

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

In Superset 3.0.0, click the ... on a chart, then Manage email report, then Set up an email report. You'll see:

a) This shouldn't say screenshot because the user can pick a text or .CSV format choice
b) This should say chart instead of dashboard

TESTING INSTRUCTIONS

N/A, just changing a line of text.

[sfirke]

I'm confused, what does this failed check say I should do?

Error: 337:14 error Replace ⏎············{t('The·report·will·be·sent·to·your·email·at')}⏎·········· with {t('The·report·will·be·sent·to·your·email·at')} prettier/prettier

EDIT: Oh of course it was the whitespace around it

[sfirke]

Also I see that the string I modified A screenshot of the dashboard will be sent to your email at appears in ten translation files when I search the code base. Should I make the corresponding modification in each of those as well?

[sfirke]

Ugh I am bad at rebasing! 😖

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (0c40bea) to head (e4dcb53).
Report is 2214 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #25540      +/-   ##
==========================================
+ Coverage   68.51%   69.09%   +0.57%     
==========================================
  Files        1915     1919       +4     
  Lines       75100    74969     -131     
  Branches     8314     8349      +35     
==========================================
+ Hits        51455    51800     +345     
+ Misses      21503    21118     -385     
+ Partials     2142     2051      -91     

Flag	Coverage Δ
javascript	57.40% <ø> (+1.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sfirke]

@rusackas I rebased this one and it's passing CI. It's not at all important but I'm pinging you in case you want to reduce the open count by one. I confirmed that this language is currently in 4.0.0rc1 and still wrong.

Updating the English makes the translations slightly out of date, I don't know how to deal with that...

[rusackas]

I suppose my only little question is this: does a user reliably know that a Report is a screenshot of a dashboard? I would assume so, but I'm not sure if this is explained elsewhere in the UI. I'll approve, since it seems fine to me, but I'll also ping @yousoph and @eschutho to see if they have feelings about it :D

[sfirke]

I suppose my only little question is this: does a user reliably know that a Report is a screenshot of a dashboard?

Ah, I sent this PR because I was setting up a Report for a single chart and didn't like that it said "dashboard." I see now that when I set up a report for a dashboard, it uses this same modal, and in that case "dashboard" and "screenshot" are correct.

Maybe that's where you're coming from? A report is not always a screenshot of a dashboard, it can be a screenshot or .csv of a single chart. Thus this fix which makes it agnostic as to which is being configured.