-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always allow tags to be returned via the API #24060
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24060 +/- ##
==========================================
+ Coverage 66.54% 68.27% +1.73%
==========================================
Files 1941 1955 +14
Lines 75280 75447 +167
Branches 8168 8215 +47
==========================================
+ Hits 50093 51511 +1418
+ Misses 23098 21830 -1268
- Partials 2089 2106 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 69 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset/dashboards/schemas.py
Outdated
@@ -169,7 +169,7 @@ class RolesSchema(Schema): | |||
class TagSchema(Schema): | |||
id = fields.Int() | |||
name = fields.String() | |||
type = fields.String() | |||
type = fields.Int() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here? Does this map to an enum? If so, can we use fields.Enum
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than what's left from Beto's comment, this lgtm.
SUMMARY
Going to soften the
TAGGING_SYSTEM
, and always allow tags to be returned regardless of the feature flag.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION