Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add loading state to sqllab save/overwrite dataset modal #23697

Merged
merged 1 commit into from
Apr 18, 2023
Merged

feat: Add loading state to sqllab save/overwrite dataset modal #23697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ export const SaveDatasetModal = ({
const [selectedDatasetToOverwrite, setSelectedDatasetToOverwrite] = useState<
SelectValue | undefined
>(undefined);
const [loading, setLoading] = useState<boolean>(false);

const user = useSelector<SqlLabExploreRootState, User>(user =>
getInitialState(user),
Expand All @@ -197,6 +198,7 @@ export const SaveDatasetModal = ({
setShouldOverwriteDataset(true);
return;
}
setLoading(true);
const [, key] = await Promise.all([
updateDataset(
datasource?.dbId,
Expand All @@ -220,6 +222,7 @@ export const SaveDatasetModal = ({
}),
}),
]);
setLoading(false);

const url = mountExploreUrl(null, {
[URL_PARAMS.formDataKey.name]: key,
Expand Down Expand Up @@ -269,6 +272,7 @@ export const SaveDatasetModal = ({
);

const handleSaveInDataset = () => {
setLoading(true);
const selectedColumns = datasource?.columns ?? [];

// The filters param is only used to test jinja templates.
Expand Down Expand Up @@ -306,6 +310,7 @@ export const SaveDatasetModal = ({
}),
)
.then((key: string) => {
setLoading(false);
const url = mountExploreUrl(null, {
[URL_PARAMS.formDataKey.name]: key,
});
Expand All @@ -314,6 +319,7 @@ export const SaveDatasetModal = ({
onHide();
})
.catch(() => {
setLoading(false);
addDangerToast(t('An error occurred saving dataset'));
});
};
Expand Down Expand Up @@ -356,6 +362,7 @@ export const SaveDatasetModal = ({
disabled={disableSaveAndExploreBtn}
buttonStyle="primary"
onClick={handleSaveInDataset}
loading={loading}
>
{buttonTextOnSave}
</Button>
Expand All @@ -370,6 +377,7 @@ export const SaveDatasetModal = ({
buttonStyle="primary"
onClick={handleOverwriteDataset}
disabled={disableSaveAndExploreBtn}
loading={loading}
>
{buttonTextOnOverwrite}
</Button>
Expand Down