Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): update messages.po(t) and add missing German translations #23402

Merged
merged 8 commits into from
Apr 7, 2023
Merged

feat(lang): update messages.po(t) and add missing German translations #23402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d95a9b1
chore: update message files
hbruch Mar 13, 2023
e7c5702
feat(lang): add missing German translations
hbruch Mar 16, 2023
57a58cf
fix: remove duplicated empty lines at file end
hbruch Mar 18, 2023
c599576
fix: remove unnecessary blankline at EOF from po/pot files
hbruch Mar 22, 2023
32e0768
fix: rename and regenerate pt messages.po file
hbruch Mar 22, 2023
dee01ba
chore: regenerate messages.json files
hbruch Mar 22, 2023
8a331cd
chore: regenerate pot/po/json files
hbruch Apr 7, 2023
ddb69bb
feat(lang): add German translations for new messages
hbruch Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/babel_update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,17 @@ pybabel update \
-d superset/translations \
--ignore-obsolete

# Chop off last blankline from po/pot files, see https://github.com/python-babel/babel/issues/799
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the extra line causing a problem (e.g. linting issues) or is this just cleanup to feel good about things? Only asking because the other solution might be to tweak the linting rule for these files. This seems fine, I'm just curious. ¯\_(ツ)_/¯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated empty line was reported by a linting rule, indeed.

for file in $( find superset/translations/** );
do
extension=${file##*.}
filename="${file%.*}"
if [ $extension == "po" ] || [ $extension == "pot" ]
then
mv $file $file.tmp
sed "$ d" $file.tmp > $file
rm $file.tmp
fi
done

cd $CURRENT_DIR
2,434 changes: 1,904 additions & 530 deletions superset/translations/de/LC_MESSAGES/messages.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading