Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate /superset/schemas_access_for_file_upload to v1 #23033

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Continuing the effort on deprecating all /superset/ REST API endpoints
Deprecates /superset/schemas_access_for_file_upload for /api/v1/database/{id}/schemas_access_for_file_upload

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #23033 (7250343) into master (50f1e2e) will increase coverage by 1.81%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master   #23033      +/-   ##
==========================================
+ Coverage   65.65%   67.46%   +1.81%     
==========================================
  Files        1878     1878              
  Lines       72152    72184      +32     
  Branches     7868     7868              
==========================================
+ Hits        47370    48699    +1329     
+ Misses      22763    21466    -1297     
  Partials     2019     2019              
Flag Coverage Δ
hive 52.71% <40.90%> (?)
javascript 53.81% <ø> (ø)
mysql 78.24% <77.27%> (-0.01%) ⬇️
postgres 78.31% <77.27%> (+<0.01%) ⬆️
presto 52.60% <40.90%> (?)
python 82.17% <77.27%> (+3.75%) ⬆️
sqlite 76.63% <72.72%> (+0.01%) ⬆️
unit 52.49% <40.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/constants.py 100.00% <ø> (ø)
superset/databases/api.py 90.64% <73.68%> (+1.72%) ⬆️
superset/databases/schemas.py 98.38% <100.00%> (+3.25%) ⬆️
superset/views/core.py 74.65% <100.00%> (+0.01%) ⬆️
superset/models/core.py 90.25% <0.00%> (+0.21%) ⬆️
superset/sql_lab.py 86.41% <0.00%> (+0.37%) ⬆️
superset/views/base_api.py 98.44% <0.00%> (+0.38%) ⬆️
superset/databases/commands/test_connection.py 90.81% <0.00%> (+1.02%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/db_engine_specs/impala.py 46.15% <0.00%> (+1.28%) ⬆️
... and 83 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@diegomedina248 diegomedina248 force-pushed the dm/chore/migrate-schemas-access-for-file-upload-to-v1 branch from 8a61273 to 7250343 Compare February 8, 2023 14:55
@hughhhh hughhhh closed this Feb 28, 2023
@mistercrunch mistercrunch deleted the dm/chore/migrate-schemas-access-for-file-upload-to-v1 branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants