Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add waitress for win32 platform #22935

Merged
merged 1 commit into from
Feb 2, 2023
Merged

chore: add waitress for win32 platform #22935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def get_git_sha() -> str:
"func_timeout",
"geopy",
"graphlib-backport",
"gunicorn>=20.1.0",
"gunicorn>=20.1.0; sys_platform != 'win32'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you run pip-compile after updating this: https://github.com/apache/superset/blob/master/CONTRIBUTING.md#dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it may need to be run on a linux-based machine in order to not break things 😬

Copy link
Contributor Author

@EugeneTorap EugeneTorap Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craig-rueda I run pip-compile-multi on Mac M1 and nothing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's probably expected

"hashids>=1.3.1, <2",
"holidays>=0.17.2, <0.18",
"humanize",
Expand Down Expand Up @@ -122,6 +122,7 @@ def get_git_sha() -> str:
"sqlparse>=0.4.3, <0.5",
"tabulate>=0.8.9, <0.9",
"typing-extensions>=4, <5",
"waitress; sys_platform == 'win32'",
"wtforms>=2.3.3, <2.4",
"wtforms-json",
"xlsxwriter>=3.0.7, <3.1",
Expand Down