feat(datasets): Change in API to create virtual datasets

[sinhashubham95]

SUMMARY

The create API for datasets only allows the creation of physical datasets. This makes the ability to directly create virtual datasets not possible. This adds a support for the same. This is a non-breaking change, adding a non-mandatory parameter in the request body.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TESTING INSTRUCTIONS

curl --location --request POST 'http://localhost:8088/api/v1/dataset/' \ --header 'Content-Type: application/json' \ --header 'Cookie: ${COOKIE}' \ --header 'Origin: http://localhost:8088' \ --header 'Referer: http://localhost:8088/swagger/v1' \ --header 'accept: application/json' \ --header 'X-csrftoken: ${CSRF_TOKEN}' \ --data-raw '{ "database": 1, "external_url": "", "is_managed_externally": false, "owners": [ 1 ], "sql": "select a.*,b.name from ab_permission_view a join ab_permission b on a.permission_id = b.id", "schema": "public", "table_name": "test1234" }'

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21840 (5e84c5b) into master (8f4415b) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21840      +/-   ##
==========================================
+ Coverage   66.18%   66.93%   +0.74%     
==========================================
  Files        1805     1805              
  Lines       69066    69068       +2     
  Branches     7369     7369              
==========================================
+ Hits        45712    46230     +518     
+ Misses      21448    20932     -516     
  Partials     1906     1906              

Flag	Coverage Δ
hive	52.92% <50.00%> (-0.01%)	⬇️
mysql	78.35% <100.00%> (?)
postgres	78.41% <100.00%> (?)
presto	52.82% <50.00%> (-0.01%)	⬇️
python	81.47% <100.00%> (+1.54%)	⬆️
sqlite	76.89% <50.00%> (-0.01%)	⬇️
unit	51.06% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/datasets/api.py	87.39% <100.00%> (+35.77%)	⬆️
superset/datasets/commands/create.py	100.00% <100.00%> (+68.75%)	⬆️
superset/datasets/schemas.py	97.40% <100.00%> (+0.01%)	⬆️
superset/db_engine_specs/base.py	89.69% <0.00%> (+0.15%)	⬆️
superset/views/core.py	76.06% <0.00%> (+0.45%)	⬆️
superset/common/query_object.py	94.38% <0.00%> (+0.51%)	⬆️
superset/connectors/sqla/models.py	91.01% <0.00%> (+0.51%)	⬆️
superset/commands/importers/v1/utils.py	93.50% <0.00%> (+1.29%)	⬆️
superset/models/core.py	90.11% <0.00%> (+1.41%)	⬆️
superset/views/base_api.py	98.44% <0.00%> (+1.55%)	⬆️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sinhashubham95]

@villebro can you please check on this?

[villebro]

Nice, I'll review shortly

[sinhashubham95]

@villebro any update here?

[villebro]

LGTM, thanks for implementing this and adding test coverage!