Hotfix. Put back a default count * metric #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you test this in explore v1 and v2? i don't see why it would work for one and not the other, but would be good to double check. |
mistercrunch
reviewed
Feb 2, 2017
| @@ -269,7 +269,7 @@ def query_obj(self): | |||
| """Building a query object""" | |||
| form_data = self.form_data | |||
| groupby = form_data.get("groupby") or [] | |||
| metrics = form_data.get("metrics") or [] | |||
| metrics = form_data.get("metrics") or ['count'] | |||
There was a problem hiding this comment.
This is a mostly-safe assumption as we create that metric on behalf of the user. Though a user could remove that metric, of a new datasource type may not know that it has to create a count by default.
I had to dealt with this while deprecating v1 as defaults are now set on the client side and decided to take the first metric from the list of possible metric for the datasource.
I'm fine either way, just wanted to chime in.
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.