-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove obsolete HiveEngineSpec.fetch_logs method #20631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20631 +/- ##
==========================================
+ Coverage 65.76% 66.56% +0.80%
==========================================
Files 1813 1791 -22
Lines 69437 68609 -828
Branches 7450 7318 -132
==========================================
+ Hits 45667 45672 +5
+ Misses 21850 21044 -806
+ Partials 1920 1893 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d04bd8f
to
4b1dca2
Compare
4b1dca2
to
d53bc04
Compare
d53bc04
to
cd6b271
Compare
cd6b271
to
eb794a2
Compare
eb794a2
to
37265bd
Compare
Delete hive.py Update hive.py
37265bd
to
e9ed8ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
PyHive now contains the fetch_log method which makes the
HiveEngineSpec.fetch_logs()
method obsolete—per the comment it mentioned it should be contributed back to PyHive.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION