Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embedded): CSV download for chart #20261

Merged
merged 31 commits into from
Jun 18, 2022
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
77e8970
move postForm to superset client
Jun 3, 2022
3748b98
lint
Jun 3, 2022
90087c5
fix lint
Jun 3, 2022
ebca313
fix type
Jun 3, 2022
e2bc61c
Merge branch 'master' of https://github.com/preset-io/incubator-super…
Jun 6, 2022
c79bcfa
update tests
Jun 6, 2022
32409c9
Merge branch 'master' of https://github.com/preset-io/incubator-super…
Jun 7, 2022
4c0a407
add tests
Jun 7, 2022
4eaeb22
add test for form submit
Jun 8, 2022
aa8a55e
add test for request form
Jun 8, 2022
dc49040
lint
Jun 8, 2022
44c4d5a
fix test
Jun 8, 2022
3260fec
fix tests
Jun 8, 2022
590c0e6
more tests
Jun 8, 2022
63a47d1
more tests
Jun 8, 2022
f3bf4bb
test
Jun 9, 2022
5db8bec
Merge branch 'master' of https://github.com/preset-io/superset into f…
Jun 9, 2022
143a588
lint
Jun 9, 2022
e77f12e
more test for postForm
Jun 9, 2022
41ca02a
Merge branch 'master' of https://github.com/preset-io/superset into f…
Jun 9, 2022
4f916d1
Merge branch 'master' of https://github.com/preset-io/incubator-super…
Jun 15, 2022
2acf6e8
lint
Jun 15, 2022
019198b
Update superset-frontend/packages/superset-ui-core/test/connection/Su…
Jun 17, 2022
6dbed55
update tests
Jun 17, 2022
361bd6a
remove useless test
Jun 17, 2022
661f3fc
make test cover happy
Jun 18, 2022
8461938
Merge branch 'master' of https://github.com/preset-io/incubator-super…
Jun 18, 2022
129c360
make test cover happy
Jun 18, 2022
78bd39e
make test cover happy
Jun 18, 2022
88a6dfa
make codecov happy
Jun 18, 2022
d7974f1
make codecov happy
Jun 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make test cover happy
  • Loading branch information
Lily Kuang committed Jun 18, 2022
commit 661f3fc6523d9178e9fc9181ab6dbb722b2c6b51
Original file line number Diff line number Diff line change
Expand Up @@ -693,5 +693,11 @@ describe('SupersetClientClass', () => {
expect(removeChild.mock.calls).toHaveLength(1);
expect(submit.mock.calls).toHaveLength(1);
});

it('should do nothing when url is empty string', async () => {
await client.init();
const result = await client.postForm('', {});
expect(result).toBeUndefined();
});
});
});