-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart & filters): make to padding between textarea and buttons #20026
fix(chart & filters): make to padding between textarea and buttons #20026
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20026 +/- ##
=======================================
Coverage 66.33% 66.33%
=======================================
Files 1713 1713
Lines 64082 64085 +3
Branches 6734 6734
=======================================
+ Hits 42509 42511 +2
- Misses 19862 19863 +1
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
/testenv up |
@stephenLYZ Ephemeral environment spinning up at http://35.167.217.29:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ephemeral environment shutdown and build artifacts deleted. |
…pache#20026) * fix(chart & filters): make to padding between textarea and buttons * fix(chart & filters): make to change static pixel to them.gridUnit * fix(chart & filters): make to fix lint issue
SUMMARY
Padding between TextArea and Buttons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:

AFTER:

TESTING INSTRUCTIONS
How to reproduce issues
ADDITIONAL INFORMATION