Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate old API and create new API for dashes created by me #19434

Merged
merged 17 commits into from
Apr 8, 2022
Merged

feat: deprecate old API and create new API for dashes created by me #19434

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
468463c
feat: deprecate old API and create new API for dashes created by me
dpgaspar Mar 30, 2022
9262ca6
Merge branch 'master' into feat/dashboards-created-by-me
dpgaspar Mar 31, 2022
e59507e
add tests
dpgaspar Mar 31, 2022
4bdef8b
fix previous test
dpgaspar Apr 1, 2022
e697782
fix test and lint
dpgaspar Apr 1, 2022
00b1681
fix sqlite test
dpgaspar Apr 5, 2022
7948e83
fix lint
dpgaspar Apr 5, 2022
963bf96
fix lint
dpgaspar Apr 5, 2022
03267d3
lint
dpgaspar Apr 5, 2022
f9c7f74
fix tests
dpgaspar Apr 6, 2022
5f1ba5f
fix tests
dpgaspar Apr 6, 2022
905b39d
Merge branch 'master' into feat/dashboards-created-by-me
dpgaspar Apr 6, 2022
58d3df7
use dashboards get list instead
dpgaspar Apr 7, 2022
94b7073
clean unnecessary marshmallow schema
dpgaspar Apr 7, 2022
fa473f7
Update superset/views/core.py
dpgaspar Apr 7, 2022
585e47d
lint
dpgaspar Apr 7, 2022
0a454e3
Merge remote-tracking branch 'origin/feat/dashboards-created-by-me' i…
dpgaspar Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@dpgaspar
dpgaspar committed Apr 6, 2022
commit f9c7f74920f5ef72201cfcb512022699a3ef020a
6 changes: 3 additions & 3 deletions tests/integration_tests/dashboards/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
# isort:skip_file
"""Unit tests for Superset"""
import json
from datetime import datetime
from io import BytesIO
from typing import List, Optional
from unittest.mock import patch
Expand Down Expand Up @@ -697,7 +698,6 @@ def test_gets_not_certified_dashboards_filter(self):
self.assertEqual(data["count"], 6)

@pytest.mark.usefixtures("create_created_by_admin_dashboards")
@pytest.mark.usefixtures("create_dashboards")
def test_get_dashboards_created_by_me(self):
"""
Dashboard API: Test get dashboards created by current user
Expand All @@ -715,12 +715,12 @@ def test_get_dashboards_created_by_me(self):
"title",
"url",
]
if backend() == "sqlite":
if backend() == "postgres":
# sqlite doesn't support ms timestamps not possible to infer proper ordering
return
expected_results = [
{"title": "create_title0", "url": "/superset/dashboard/create_slug0/"},
{"title": "create_title1", "url": "/superset/dashboard/create_slug1/"},
{"title": "create_title0", "url": "/superset/dashboard/create_slug0/"},
]
for idx, response_item in enumerate(data["result"]):
for key, value in expected_results[idx].items():
Expand Down