Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time filter should be [start, end) #19166

Merged
merged 7 commits into from
Mar 17, 2022
Merged

fix: time filter should be [start, end) #19166

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b62e4e
fix: time filter should be [start, end)
zhaoyongjie Mar 16, 2022
d023a7e
add ut
zhaoyongjie Mar 16, 2022
1c9224a
minor fix
zhaoyongjie Mar 16, 2022
aae7e27
minor fix
zhaoyongjie Mar 16, 2022
5c97116
minor fix
zhaoyongjie Mar 16, 2022
b74937b
minor fix
zhaoyongjie Mar 16, 2022
1d719be
more accurate ut
zhaoyongjie Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fix
  • Loading branch information
@zhaoyongjie
zhaoyongjie committed Mar 16, 2022
commit 1c9224a5275f3329c3e13fc978fd4aaba9b7f85f
2 changes: 1 addition & 1 deletion tests/integration_tests/sqla_models_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ def test_filter_on_text_column(text_column_table):

def test_should_generate_closed_and_open_time_filter_range():
with app.app_context():
if backend() in ["sqlite", "mysql"]:
if backend() != "postgresql":
pytest.skip(f"{backend()} has different dialect for datetime column")

table = SqlaTable(
Expand Down