[explore] show the broken query when failing #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
return_sql
branch
from
68557d4 to
2340187
Compare
ascott
reviewed
Jan 4, 2017
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| from datetime import datetime, timedelta | |||
| import json | |||
| import simplejson as sjson | |||
There was a problem hiding this comment.
looks like we import this as import simplejson as json in other modules. i find sjson looks like a typo to me. either way, being consistent and importing simplejson the same var name seems like a good idea.
There was a problem hiding this comment.
I was avoiding the conflict as I moved the line import simplejson as json line from another file but can simply import simplejson
|
generally lgtm. |
mistercrunch
force-pushed
the
return_sql
branch
from
f316d5e to
e787d1d
Compare
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
* Return query when failing * Linting * sjson -> simplejson
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a query fails for whatever reason, the previous query is shown in the
Querymodal. It's confusing and makes it hard to debug things.This PR addresses the problem both in v1 and v2, making sure the endpoint returns a rich json object that contains all the detail available even in case of failure.
Related improvements/refactor:
alwaysfunction in explorev1, for logic that needs to happen on failure and successBaseViznow returns an data structure, not a json string, to allow the view to read what was returned and assign a proper error codeget_dfmethods for viz that really didn't need it, logic merged inget_data