-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-table): sort alphanumeric columns case insensitive #17765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17765 +/- ##
=======================================
Coverage 67.71% 67.72%
=======================================
Files 1604 1605 +1
Lines 64186 64195 +9
Branches 6786 6789 +3
=======================================
+ Hits 43464 43473 +9
Misses 18867 18867
Partials 1855 1855
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@kgabryje Ephemeral environment spinning up at http://34.215.199.149:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works, too!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR makes sorting of alphanumeric columns case insensitive.
Order of sorting before (ascending):
Order of sorting after (ascending):
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2021-12-15.at.17.03.55.mov
After:
Screen.Recording.2021-12-15.at.16.58.59.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @rusackas
https://app.shortcut.com/preset/story/25784/column-sort-should-be-case-insensitive